feat: add "cache" input for disabling rpc caching #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRBerg
force-pushed
the
optional-caching
branch
from
f7a339c
to
d4f5b80
Compare
chore: git ignore ".vscode" directory docs: document how to manually delete caches refactor: restore and save cache only if "cache" input is "true"
PaulRBerg
force-pushed
the
optional-caching
branch
from
d4f5b80
to
99fa5c6
Compare
|
@gakonst any chance you could take a quick look at this? The review should be fast, since this is a backwards compatible change. The default behavior will remain to cache the RPC responses for users. |
gakonst
approved these changes
Feb 1, 2023
|
Thanks @gakonst - I think we also need to bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #22.
@sambacha, you owe me a beer.
Changelog