Excluding screaming-snake-case-immutable lint does not work

[mattstam]

Component

Forge

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

Forge Version: 1.3.0-v1.3.0

What version of Foundryup are you on?

foundryup: 1.3.0

What command(s) is the bug in?

forge build, forge lint

Operating System

macOS (Apple Silicon)

Describe the bug

exclude_lints = ["screaming-snake-case-immutable"] does not actually exclude them. for example with this set you still see:

note[screaming-snake-case-immutable]: immutables should use SCREAMING_SNAKE_CASE
  --> /Users/mattstam/go/src/github.com/succinctlabs/network/contracts/src/mocks/MockVApp.sol:53:30
   |
53 |     address public immutable feeVault;
   |                              --------
   |
   = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-immutable

note[screaming-snake-case-immutable]: immutables should use SCREAMING_SNAKE_CASE
  --> /Users/mattstam/go/src/github.com/succinctlabs/network/contracts/src/mocks/MockVApp.sol:54:30
   |
54 |     uint256 public immutable protocolFeeBips;
   |                              ---------------
   |
   = help: https://book.getfoundry.sh/reference/forge/forge-lint#screaming-snake-case-immutable

Reproducible here: https://github.com/succinctlabs/network

Just clone, and set lint_on_build = true, and forge build to show linter warnings despite screaming-snake-case-immutable being there. Notice that other ignores, such asmixed-case-variable, do work correctly.

[grandizzy]

thanks, likely same as #11080 which should be fixed with #11122 need to confirm

[0xrusowsky]

correct. same issue, should be fixed once we merge

[grandizzy]

I tested and confirming will be solved with #11122, going to mark as dupe of #11080 Thank you

[0xrusowsky]

fyi it has been merge. should be fixed on the next nightly