forge: verify on plasma should retry if contract not found

[sakulstra]

Component

Forge

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

9dc83c9

What version of Foundryup are you on?

No response

What command(s) is the bug in?

forge script

Operating System

None

Describe the bug

On latest nightly (i think is not related to nightly but fukasa gas price drops), when i try to submit a txn on optimism, txns error with:
Sequence #1 on optimism | retrying transaction Err(server returned an error response: error code -32000: insufficient gas for floor data gas cost: gas 719122, minimum needed 741890) and similar

[sakulstra]

On gnosis chain, seems like foundry also can no longer submit txns.

## Setting up 1 EVM.

==========================

Chain 100

Estimated gas price: 0.000000101 gwei

Seems to dramatically underestimate gas cost: https://gnosisscan.io/gastracker

[sakulstra]

Sorry will just dump here issues i face while i face them as i need to deploy sth on various chains 😅

On Plasma, verification failed initially because I think etherscan is not fast enough.

Response: `NOTOK`
Details: `Error: contract does not exist 9745 0x<sth>

Manual verification works, but probably would be good if foundry retried when contract does not exist (and it knows it exists, given it just deployed).

[grandizzy]

Sorry will just dump here issues i face while i face them as i need to deploy sth on various chains 😅

On Plasama, verification failed initially because I think etherscan is not fast enough.

Response: `NOTOK`
Details: `Error: contract does not exist 9745 0x<sth>

Manual verification works, but probably would be good if foundry retried when contract does not exist (and it knows it exists, given it just deployed).

@sakulstra for this you could tweak the params

      --retries <RETRIES>
          Number of attempts for retrying verification
          
          [default: 5]

      --delay <DELAY>
          Optional delay to apply in between verification attempts, in seconds
          
          [default: 5]

[sakulstra]

@grandizzy Will try next time, but honestly feels like this should be the default.
At least with this error it's quite obvious that the explorer lags behind.

Also on polygon, without any custom settings it does:

Submitting verification for [src/UpgradePayload.sol:UpgradePayload] 0x<sth>.
Warning: Could not detect deployment: Unable to locate ContractCode at <sth>; waiting 5 seconds before trying again (4 tries remaining)

Submitting verification for [src/UpgradePayload.sol:UpgradePayload] <sth>.
Warning: Could not detect deployment: Unable to locate ContractCode at <sth>; waiting 5 seconds before trying again (3 tries remaining)

Submitting verification for [src/UpgradePayload.sol:UpgradePayload] <sth>.
Warning: Could not detect deployment: Unable to locate ContractCode at <sth>; waiting 5 seconds before trying again (2 tries remaining)

Submitting verification for [src/UpgradePayload.sol:UpgradePayload] <sth>.
Warning: Could not detect deployment: Unable to locate ContractCode at <sth>; waiting 5 seconds before trying again (1 tries remaining)

Submitting verification for [src/UpgradePayload.sol:UpgradePayload] <sth>.
Warning: Could not detect deployment: Unable to locate ContractCode at <sth>; waiting 5 seconds before trying again (0 tries remaining)

So it seems to kinda handle it, but inconsistently.

[grandizzy]

I see will bump both defaults to 10 then

[aganisgash]

On latest nightly (i think is not related to nightly but fukasa gas price drops), when i try to submit a txn on optimism, txns error with: Sequence #1 on optimism | retrying transaction Err(server returned an error response: error code -32000: insufficient gas for floor data gas cost: gas 719122, minimum needed 741890) and similar

I think here its not foundry to estimate the gas? Maybe some RPC side issue? cc @grandizzy

[sakulstra]

I think here its not foundry to estimate the gas? Maybe some RPC side issue?

Was using alchemy and today it seems to work.
Perhaps it's them not properly handling the floor price.

[grandizzy]

@sakulstra if all good now we could keep this to bump the retries as in linked PR, pls comment

[grandizzy]

@sakulstra can you pls rerun with RUST_LOG=trace and send the response that is logged as Received verification response need that to properly handle the plasma API response. Or if you could provide verifier url details to repro locally, thank you