Contract name and filename collisions

[antonper]

Component

Forge

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

forge 0.2.0 (a97090d 2022-05-02T00:04:10.711117948+00:00)

What command(s) is the bug in?

forge build

Operating System

Linux

Describe the bug

File structure:

├── src
│   ├── a.sol
│   └── inner
│       └── a.sol

src/a.sol

// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

contract A {
  function bar() public {
  }
}

src/inner/a.sol

// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

contract A {
  function bar() public {
  }
}
contract B {
  function foo() public {
  }
}

After running forge build I have following file structure:

├── out
│   └── a.sol
│       ├── A.json
│       └── B.json

The content of out json files corresponds to inner/a.sol. No data will be in out folder for the src/a.sol file.
Similar thing happens if A inside inner/a.sol is an interface. This is a bit unusual to define same contracts in files with same names, but may be something like a warning is a good option here.

[mattsse]

sorry for the wait, investigating this and add a fix to prevent collisions where count((filename, contractname)) > 1

[0xalpharush]

Can this be prioritized? Several users of slither have encountered this collision error, and there's not an easy way to bypass aside from switching to hardhat.

[mattsse]

bumping, trying to fix this asap

[mattsse]

this was fixed with gakonst/ethers-rs#1487 gakonst/ethers-rs#1491