This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(solc): handle conflicting artifacts properly #1491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1487
this changes how output files are computed and now takes possible conflicts into account.
this doesn't change how artifacts were emitted up to now and only adds extra logic if there are conflicting files.
maybe there'll be some edge cases with caching, but hard to anticipate at this point.
this also passes all existing foundry tests with a patched version
Solution
change emit logic:
PR Checklist