Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify names of supported chains #1564

Closed
mattsse opened this issue May 9, 2022 · 3 comments · Fixed by #1636
Closed

Unify names of supported chains #1564

mattsse opened this issue May 9, 2022 · 3 comments · Fixed by #1636
Assignees
@shawnharmsen
Labels
C-cast Command: cast C-forge Command: forge D-easy Difficulty: easy good first issue Good for newcomers T-debt Type: code debt

Comments

@mattsse
Copy link
Member

mattsse commented May 9, 2022

Component

Forge

Describe the feature you would like

Currently we're using

foundry/cli/src/opts/mod.rs

Lines 40 to 57 in ed4eb2d

possible_values = [
"mainnet",
"ropsten",
"rinkeby",
"goerli",
"kovan",
"xdai",
"polygon",
"polygon_mumbai",
"avalanche",
"avalanche_fuji",
"sepolia",
"moonbeam",
"moonbeam_dev",
"moonriver",
"optimism",
"optimism-kovan"
])]

in several places, ideally, this should be a single function that's then set as argument in the clap attribute, if possible

Additional context

No response
@mattsse mattsse added the T-feature Type: feature label May 9, 2022
@onbjerg onbjerg added this to Foundry May 9, 2022
@onbjerg onbjerg moved this to Todo in Foundry May 9, 2022
@mattsse mattsse changed the title Unify supported named chain ids Unify names of supported chains May 9, 2022
@onbjerg
Copy link
Member

onbjerg commented May 10, 2022

Any reason we didn't use #[derive(ArgEnum)] (see here)? 🤔

@onbjerg onbjerg added C-cast Command: cast C-forge Command: forge T-debt Type: code debt and removed T-feature Type: feature labels May 10, 2022
@mattsse
Copy link
Member Author

mattsse commented May 10, 2022

lol TIL

let's try that.

this would be an easy pick up if anyone's looking for an easy issue

@mattsse mattsse added the D-easy Difficulty: easy label May 10, 2022
@onbjerg onbjerg added the good first issue Good for newcomers label May 10, 2022
@shawnharmsen
Copy link
Contributor

I'd like to take this one today, will add PR soon

This was referenced May 11, 2022
Closed
Merged
@onbjerg onbjerg moved this from Todo to In Progress in Foundry May 12, 2022
@shawnharmsen shawnharmsen mentioned this issue May 17, 2022
Merged
Repository owner moved this from In Progress to Done in Foundry May 17, 2022
@shawnharmsen shawnharmsen mentioned this issue May 17, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnharmsen shawnharmsen

Labels
C-cast Command: cast C-forge Command: forge D-easy Difficulty: easy good first issue Good for newcomers T-debt Type: code debt
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unify names of supported chains shawnharmsen/foundry
3 participants
@shawnharmsen @onbjerg @mattsse