Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clapchain possible_values using manual list of chains #1641

Closed
2 tasks done
shawnharmsen opened this issue May 17, 2022 · 0 comments · Fixed by #1642
Closed
2 tasks done

clapchain possible_values using manual list of chains #1641

shawnharmsen opened this issue May 17, 2022 · 0 comments · Fixed by #1642
Labels
T-bug Type: bug

Comments

@shawnharmsen
Copy link
Contributor

Component

Cast

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

cast 0.2.0 (baa5233 2022-05-17T00:08:57.303043Z)

What command(s) is the bug in?

cast etherscan-source -c goerli 0xf5de760f2e916647fd766B4AD9E85ff943cE3A2b

Operating System

macOS (Apple Silicon)

Describe the bug

Previous issue:
#1564

Motivation:

Forgot to fix clapchain possible_values

possible_values = [
"mainnet",
"ropsten",
"rinkeby",
"goerli",
"kovan",
"xdai",
"polygon",
"polygon_mumbai",
"avalanche",
"avalanche_fuji",
"sepolia",
"moonbeam",
"moonbeam_dev",
"moonriver",
"optimism",
"optimism-kovan"
])]

Solution:

Change ClapChain possible values to strum::VARIANTS

@shawnharmsen shawnharmsen added the T-bug Type: bug label May 17, 2022
@onbjerg onbjerg added this to Foundry May 17, 2022
@onbjerg onbjerg moved this to Todo in Foundry May 17, 2022
Repository owner moved this from Todo to Done in Foundry May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant