Issue with arguments using forge create

[crisgarner]

Currently deploying a contract with multiple arguments require forge create command to use multiple times the param --constructor-args

forge create Token --constructor-args "My token" --constructor-args "TKN" --constructor-args 18 --mnemonic-path XXX --rpc-url XXX

Suggestion, change it to only require one argument call

forge create Token --constructor-args "My token" "TKN" 18 --mnemonic-path XXX --rpc-url XXX

Fix might be around here: https://github.com/gakonst/foundry/blob/master/cli/src/cmd/create.rs#L54-L55

[gakonst]

Could also be clap related? https://github.com/gakonst/foundry/blob/master/cli/src/cmd/create.rs#L22-L23

[gakonst]

Should we deprecate forge create altogether in favor of the whole forge deploy workflow, or would it still be useful for "quick" deployments of single files? #402

[brockelmore]

i think it will remain useful - create is for solo contracts, deploy is deployment management of multiple imo

[fmhall]

Can we add a --verify flag to forge create? Does that make sense?

[gakonst]

@fmhall this is tracked in #287 #354

[onbjerg]

The behavior we want is Arg::multiple_values(true) (see docs) but it is not available in their derive crate, possibly because they deem it to be unsafe? What we have now is Arg::multiple_occurences(true).

We can either do Arg::mutiple_values(true) (despite the warnings) or we could add the parameters as direct arguments on the CLI (i.e. forge create MyContract "first arg" "second arg" 2 3 4)

[gakonst]

Hmm reading through the warnings, it seems like it should be fine? I don't think we'd ever have any positional arguments for --constructor-args, only named args? We can enable this with raw in clap derive if I'm not mistaken - I'd be supportive of doing that and adding a note / link to when it could be dangerous in a doc.

[onbjerg]

Yeah I think in this case it is fine

[calldata]

Anyone take this issue ?