Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support blockscout in cast etherscan-source #4776

Open
2 tasks done
sakulstra opened this issue Apr 19, 2023 · 1 comment
Open
2 tasks done

feat: support blockscout in cast etherscan-source #4776

sakulstra opened this issue Apr 19, 2023 · 1 comment
Labels
A-compatibility Area: compatibility A-config Area: config C-cast Command: cast P-low Priority: low T-feature Type: feature
Milestone

Comments

@sakulstra
Copy link
Contributor

Component

Cast

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (f7a535d 2023-04-03T00:04:12.007857053Z)

What command(s) is the bug in?

cast etherscan-source

Operating System

Linux

Describe the bug

As i understand https://github.com/gakonst/ethers-rs/blob/master/ethers-etherscan/src/contract.rs#L378 does a simple get call to a "etherscan like api".

Blockscout seems to follow that exact api:
image

So i think the command should probably be agnostic e.g. cast source and support a --api-url parameter or source the api from toml (not sure how reasonable this is as technically it's not etherscan?

[etherscan]
metis = { key="any", chainId=1088, url='https://andromeda-explorer.metis.io/api/' }
@sakulstra sakulstra added the T-bug Type: bug label Apr 19, 2023
@gakonst gakonst added this to Foundry Apr 19, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Apr 19, 2023
@mds1 mds1 added the C-cast Command: cast label Apr 20, 2023
@zerosnacks zerosnacks added A-compatibility Area: compatibility A-config Area: config labels Jul 2, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@zerosnacks zerosnacks added T-feature Type: feature and removed T-bug Type: bug labels Oct 31, 2024
@zerosnacks zerosnacks changed the title support blockscout in cast etherscan-source feat: support blockscout in cast etherscan-source Oct 31, 2024
@zerosnacks
Copy link
Member

For future reference: cast etherscan-source should be generalized to cast source and support alternative block explorers

@grandizzy grandizzy added the P-low Priority: low label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compatibility Area: compatibility A-config Area: config C-cast Command: cast P-low Priority: low T-feature Type: feature
Projects
Status: Todo
Development

No branches or pull requests

4 participants