Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat: add metis support #2365

Merged
merged 2 commits into from
Apr 25, 2023
Merged

feat: add metis support #2365

merged 2 commits into from
Apr 25, 2023

Conversation

sakulstra
Copy link
Contributor

Motivation

I wanted to use erhers-rs for Metis network

Solution

Add ing Metis in this pr

Following the example here: https://github.com/gakonst/ethers-rs/pull/2316/files

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prestwich
Copy link
Collaborator

CI failures unrelated. Please rebase and resolve conflicts, then we can merge

@sakulstra
Copy link
Contributor Author

@prestwich rebased.

When looking into metis/blockscout also noticed that some foundry commands don't work with blockscout, although blockscout claims to be etherscan compatible: foundry-rs/foundry#4776 - not quite sure where to fix this. As i understand the contract.rs is already more or less agnostic, but probably some adjustment is needed here: https://github.com/gakonst/ethers-rs/blob/master/ethers-etherscan/src/lib.rs#L78 as on blockscout there are no api keys?

@prestwich
Copy link
Collaborator

prestwich commented Apr 25, 2023

please run cargo +nightly fmt and commit the results :) The clippy CI failure may be unrelated. looking into it

When looking into metis/blockscout also noticed that some foundry commands don't work with blockscout, although blockscout claims to be etherscan compatible: foundry-rs/foundry#4776 - not quite sure where to fix this. As i understand the contract.rs is already more or less agnostic, but probably some adjustment is needed here: https://github.com/gakonst/ethers-rs/blob/master/ethers-etherscan/src/lib.rs#L78 as on blockscout there are no api keys?

I'm not sure as i don't really follow blockscout closely. This is at the very least worth a new issue

@prestwich prestwich merged commit 885e368 into gakonst:master Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants