Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge debug does not have source view #5569

Closed
2 tasks done
llllvvuu opened this issue Aug 9, 2023 · 6 comments
Closed
2 tasks done

forge debug does not have source view #5569

llllvvuu opened this issue Aug 9, 2023 · 6 comments
Labels
T-bug Type: bug

Comments

@llllvvuu
Copy link
Contributor

llllvvuu commented Aug 9, 2023

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (1a110a5 2023-08-08T16:26:20.836709000Z)

What command(s) is the bug in?

forge debug

Operating System

macOS (Apple Silicon)

Describe the bug

Create file contracts/Counter.sol: https://solidity-by-example.org/first-app/

Run: forge debug --debug contracts/Counter.sol --sig "inc()"

Result:

Screenshot 2023-08-09 at 2 57 17 AM
@llllvvuu llllvvuu added the T-bug Type: bug label Aug 9, 2023
@gakonst gakonst added this to Foundry Aug 9, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Aug 9, 2023
@emo-eth
Copy link
Contributor

emo-eth commented Aug 9, 2023

Noting that this has already been raised in #5435

Also noting that this is a major headache 😔

@Evalir
Copy link
Member

Evalir commented Aug 9, 2023

Yep @jameswenzel — I'll try to make time between tomorrow and friday to look into this so we can unblock u and more ppl on the support channel!

Let's close this issue and keep tracking on #5435

@Evalir Evalir closed this as completed Aug 9, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Aug 9, 2023
@iFrostizz
Copy link
Contributor

@Evalir please note that this very much may be fixed after that #5547 is merged. We could also do this step by step if better !

@Evalir
Copy link
Member

Evalir commented Aug 9, 2023

Right @iFrostizz ! That'd be awesome if the refactor fixed it. A quick fix for this would also be appreciated for this if you know the cause!

@llllvvuu
Copy link
Contributor Author

llllvvuu commented Aug 9, 2023

If there's a refactor y'all might find Debug Adapter Protocol interesting; lets people use VSCode/Vim/whatever as the frontend. I don't think the VSCode UI is necessarily that much better, if at all, but idk, using standard framework could turn out to be easier to build/maintain

Example, rust-analyzer has a pretty nifty CodeLens (although they may switch to VSCode-specific API) for debug test which I believe passes off to DAP (e.g. lldb):
146777918-e3274bf6-200a-4254-96aa-b5b38fa3eda5.png

@iFrostizz
Copy link
Contributor

You might wanna try my branch #5547 tho the source mapping may be incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
Archived in project
Development

No branches or pull requests

4 participants