Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(forge): flatten includes unnecessary ; #641

Closed
2 tasks done
degatchi opened this issue Jan 30, 2022 · 2 comments
Closed
2 tasks done

bug(forge): flatten includes unnecessary ; #641

degatchi opened this issue Jan 30, 2022 · 2 comments
Labels
C-forge Command: forge D-easy Difficulty: easy P-normal Priority: normal T-bug Type: bug

Comments

@degatchi
Copy link

degatchi commented Jan 30, 2022 •
edited
Loading

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.1.0 (708f48f 2022-01-30T00:25:30.497347+00:00)

What command(s) is the bug in?

forge flatten

Operating System

macOS (amd)

Describe the bug

When flattening a contract that inherits multiple contracts, majority of the contracts' closing braces had semi colons at the end and just wondering around after comments.

image

image

image
@degatchi degatchi added the T-bug Type: bug label Jan 30, 2022
@degatchi degatchi changed the title forge flatten }; bug BUG | forge flatten }; Jan 30, 2022
@degatchi degatchi changed the title BUG | forge flatten }; Bug : forge flatten }; Jan 30, 2022
@brockelmore brockelmore changed the title Bug : forge flatten }; bug(forge): flatten includes unnecessary ; Jan 30, 2022
@brockelmore brockelmore added C-forge Command: forge D-easy Difficulty: easy P-normal Priority: normal labels Jan 30, 2022
@mattsse
Copy link
Member

mattsse commented Jan 30, 2022

cc @rkrasiuk

@rkrasiuk
Copy link
Collaborator

@mattsse thanks for tagging, looking over it rn

@rkrasiuk rkrasiuk mentioned this issue Jan 31, 2022
Merged
3 tasks
charisma98 added a commit to charisma98/foundry that referenced this issue Mar 4, 2023
@charisma98
chore: bump ethers
cc33f18 
closes foundry-rs/foundry#597 due to alloy-rs/svm-rs#15
closes foundry-rs/foundry#641 due to gakonst/ethers-rs#846
0129general added a commit to 0129general/FoundryProject that referenced this issue May 8, 2024
@0129general
chore: bump ethers
cccce23 
closes foundry-rs/foundry#597 due to alloy-rs/svm-rs#15
closes foundry-rs/foundry#641 due to gakonst/ethers-rs#846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-forge Command: forge D-easy Difficulty: easy P-normal Priority: normal T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattsse @rkrasiuk @brockelmore @degatchi