Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge script crashes on resuming #6697

Closed
2 tasks done
yongqjn opened this issue Jan 3, 2024 · 3 comments · Fixed by #7179
Closed
2 tasks done

forge script crashes on resuming #6697

yongqjn opened this issue Jan 3, 2024 · 3 comments · Fixed by #7179
Labels
T-bug Type: bug

Comments

@yongqjn
Copy link

yongqjn commented Jan 3, 2024

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (8c11482 2023-11-16T00:32:37.968294000Z)

What command(s) is the bug in?

forge script --resume

Operating System

macOS (Apple Silicon)

Describe the bug

script runs a deployment sequence that involves cross-chain transactions

script initially exits prematurely with transaction underpriced error.

running the same script with the resume flag causes the application to crash

Screenshot 2024-01-03 at 5 06 41 PM
@yongqjn yongqjn added the T-bug Type: bug label Jan 3, 2024
@DaniPopes
Copy link
Member

DaniPopes commented Feb 19, 2024

Relevant code:

/// Returns the list of the transactions without the metadata.
pub fn typed_transactions(&self) -> Vec<(String, &TypedTransaction)> {
self.transactions
.iter()
.map(|tx| {
(tx.rpc.clone().expect("to have been filled with a proper rpc"), tx.typed_tx())
})
.collect()
}

tx.rpc here is TransactionWithMetadata::rpc, which is #[serde(skip)]:

#[serde(skip)]
pub rpc: Option<RpcUrl>,

This has been skipped due to being a sensitive value in #4892

So we fill it with fill_sensitive:

pub fn fill_sensitive(&mut self, sensitive: &SensitiveScriptSequence) {

cc @Evalir @klkvr @mattsse

@klkvr
Copy link
Member

klkvr commented Feb 19, 2024

This was fixed in #6447

@yongqjn could you please update to the latest nightly and try again?

@DaniPopes
Copy link
Member

Ah missed this was before the fill fix was implemented. Will close with #7179 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants