Fix multichain scripts resume functionality #6447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Dec 1, 2023
crates/forge/bin/cmd/script/multi.rs
Outdated
Comment on lines
38
to
41
| impl From<&mut MultiChainSequence> for SensitiveMultiChainSequence { | ||
| fn from(sequence: &mut MultiChainSequence) -> Self { | ||
| SensitiveMultiChainSequence { | ||
| deployments: sequence.deployments.iter_mut().map(|sequence| sequence.into()).collect(), | ||
| } | ||
| } |
There was a problem hiding this comment.
I'd like to have this as a function instead, from impls are harder to navigate/refactor
There was a problem hiding this comment.
You mean something like this?
fn to_sensitive(sequence: &mut MultiChainSequence) -> SensitiveMultiChainSequence {
SensitiveMultiChainSequence {
deployments: sequence.deployments.iter_mut().map(|sequence| sequence.into()).collect(),
}
}
|
Haven't reviewed code carefully but agree we should fix this so multichain resume works |
mattsse
reviewed
Dec 8, 2023
klkvr
force-pushed
the
klkvr/multi-rpcs
branch
from
733cd17
to
f2a5268
Compare
|
hey @mattsse rebased and changed impl to function |
2 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#4892 removed RPCs from general broadcast data and moved them to ./cache. However, for multichain sequences, RPC endpoints weren't saved anywhere which made resuming multichain scripts impossible
Solution
Save RPC endpoints used by multichain sequences to ./cache.
Ref #5047