Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add global Rayon thread pool (--jobs) to GlobalOpts #8408

Closed
Tracked by #8794
DaniPopes opened this issue Jul 10, 2024 · 2 comments · Fixed by #9367
Closed
Tracked by #8794

feat: add global Rayon thread pool (--jobs) to GlobalOpts #8408

DaniPopes opened this issue Jul 10, 2024 · 2 comments · Fixed by #9367
Labels
A-internals Area: internals P-low Priority: low T-feature Type: feature
Milestone
v1.0.0

Comments

@DaniPopes
Copy link
Member

Component

Other (please describe)

Describe the feature you would like

Add a struct to all CLI parsers that contains global clap options. Initially this can contain --jobs and has a helper method to spawn the global rayon pool with the configured amount of threads

Additional context

See ShellOpts from https://github.com/foundry-rs/foundry/pull/6569/files#diff-93947eff97e7f1937ebcb82f40d17f32e45c67ff18c286e675ed9fa9d0b89994
@DaniPopes DaniPopes added the T-feature Type: feature label Jul 10, 2024
@zerosnacks zerosnacks added the A-internals Area: internals label Jul 12, 2024
@zerosnacks zerosnacks changed the title Add global Clap arguments feat: add global Clap arguments Jul 16, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@jenpaff jenpaff removed this from the v1.0.0 milestone Sep 26, 2024
@DaniPopes
Copy link
Member Author

Should be possible to implement by generalizing ShellOpts after common-shell PRs are merged @zerosnacks

This was referenced Nov 1, 2024
Open
Merged
@grandizzy grandizzy added this to the v1.0.0 milestone Nov 7, 2024
@zerosnacks zerosnacks self-assigned this Nov 11, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Nov 11, 2024
@zerosnacks zerosnacks moved this from Todo to In Progress in Foundry Nov 11, 2024
@grandizzy grandizzy added the P-normal Priority: normal label Nov 12, 2024
@zerosnacks
Copy link
Member

Related: #5479

@zerosnacks zerosnacks mentioned this issue Nov 13, 2024
Merged
@zerosnacks zerosnacks moved this from In Progress to Ready For Review in Foundry Nov 18, 2024
@zerosnacks zerosnacks changed the title feat: add global Clap arguments feat: add global Rayon thread pool (--jobs) to GlobalOpts Nov 20, 2024
@zerosnacks zerosnacks added P-low Priority: low and removed P-normal Priority: normal labels Nov 20, 2024
@zerosnacks zerosnacks removed this from Foundry Nov 20, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Nov 20, 2024
@zerosnacks zerosnacks removed their assignment Nov 20, 2024
@DaniPopes DaniPopes mentioned this issue Nov 20, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-internals Area: internals P-low Priority: low T-feature Type: feature
Projects
Foundry
Status: Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

feat: add global -j, --threads foundry-rs/foundry
4 participants
@jenpaff @grandizzy @DaniPopes @zerosnacks