feat: add global -j, --threads #9367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
DaniPopes
commented
Nov 20, 2024
| @@ -898,10 +882,6 @@ impl Provider for TestArgs { | |||
| dict.insert("show_progress".to_string(), true.into()); | |||
| } | |||
|
|
|||
| if let Some(threads) = self.threads { | |||
| dict.insert("threads".to_string(), threads.into()); | |||
There was a problem hiding this comment.
we have threads in config but I don't really know where it should spawn the thread pool, and also it would conflict with the CLI arg if both are present
| jobs: Option<NonZeroUsize>, | ||
| /// Number of threads to use. Zero specifies the number of logical cores. | ||
| #[arg(global = true, long, short = 'j', visible_alias = "jobs")] | ||
| threads: Option<usize>, |
There was a problem hiding this comment.
Has the same value as the global one
zerosnacks
reviewed
Nov 20, 2024
crates/forge/bin/cmd/test/mod.rs
Outdated
Comment on lines
68
to
70
| /// Include the global options. | ||
| #[command(flatten)] | ||
| pub global: GlobalOpts, |
There was a problem hiding this comment.
This is required for the CLI tests that use TestArgs directly, same for ScriptArgs
zerosnacks
reviewed
Nov 20, 2024
DaniPopes
force-pushed
the
dani/global-threads
branch
2 times, most recently
from
c63c13a
to
bca4ec3
Compare
DaniPopes
force-pushed
the
dani/global-threads
branch
from
bca4ec3
to
9eb3651
Compare
zerosnacks
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8408