feat(config): configure RPC timeout for forge script

[kevinhalliday]

Component

Forge

Describe the feature you would like

Forge script rpc requests timeout after 45 seconds. You can increase timeout for waiting for tx receipts, but you cannot increase timeout for eth_sendTransaction requests. The feature would allow using MPC signers (like fireblocks) w/ unlocked forge scripts.

Additional context

This is a "reopening" of #8667.

Describe the feature you would like
Currently forge script rpc requests timeout after 45 seconds. I believe this is not configurable (let me know if I'm wrong). Being able to specify timeout would be 🤌

Additional context
We are running forge scripts --unlocked against a proxy rpc that intercepts eth_sendTransaction requests and signs them with fireblocks. The MPC signing takes time, often longer than 45seconds. The scripts timeout pretty consistently.

The fix (#8669) only increased timeout for waiting for tx receipts. But eth_sendTransaction requests still use constant 45 second timeout.

[grandizzy]

I think we could reuse the existing eth_rpc_timeout config when creating script providers, @zerosnacks @klkvr would this work or could be confusing?

[klkvr]

yep, we should make sure to add it to ScriptArgs

also right now scripts are using different code path than cast for creating providers, need to make it aware of timeout

foundry/crates/script/src/broadcast.rs

Line 258 in 4817280

let provider = Arc::new(try_get_http_provider(sequence.rpc_url())?);

[grandizzy]

👍 , or maybe better an --rpc-timeout in EvmArgs along with --rpc-url ?

foundry/crates/common/src/evm.rs

Lines 44 to 50 in 4817280

	pub struct EvmArgs {
	/// Fetch state over a remote endpoint instead of starting from an empty state.
	///
	/// If you want to fetch state from a specific block number, see --fork-block-number.
	#[arg(long, short, visible_alias = "rpc-url", value_name = "URL")]
	#[serde(rename = "eth_rpc_url", skip_serializing_if = "Option::is_none")]
	pub fork_url: Option<String>,

[zerosnacks]

We have an rpc_timeout in RpcOpts here

foundry/crates/cli/src/opts/ethereum.rs

Lines 44 to 50 in 4817280

	/// Timeout for the RPC request in seconds.
	///
	/// The specified timeout will be used to override the default timeout for RPC requests.
	///
	/// Default value: 45
	#[arg(long, env = "ETH_RPC_TIMEOUT")]
	pub rpc_timeout: Option<u64>,

[klkvr]

yeah that's a bit weird because we can't use both EvmArgs and RpcOpts because of --rpc-url conflict, might make sense to try unifying those

[10kumaranurag01]

I'd love to give this a go. Please assign this to me

[mimisavage]

Could I be assigned to this?