Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transaction timeout config #8669

Merged
merged 3 commits into from
Aug 22, 2024
Merged

feat: add transaction timeout config #8669

merged 3 commits into from
Aug 22, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Aug 14, 2024

Motivation

Closes #8667

Solution

Adds --timeout option to forge create, forge script and cast send. Also supports transaction_timeout config key and ETH_TIMEOUT env var

Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse
Copy link
Member

mattsse commented Aug 22, 2024

pending conflicts :)

@klkvr klkvr merged commit 33aae9e into master Aug 22, 2024
20 checks passed
@klkvr klkvr deleted the klkvr/tx-timeout branch August 22, 2024 10:43
benwjhack pushed a commit to CompassLabs/foundry-test that referenced this pull request Sep 11, 2024
* feat: add transaction timeout config

* clipppy

* fix doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(config): configure RPC timeout for forge script
3 participants