Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong lines in "forge coverage --report lcov" #9437

Closed
1 of 2 tasks
krakovia-evm opened this issue Nov 29, 2024 · 4 comments · Fixed by #9438
Closed
1 of 2 tasks

wrong lines in "forge coverage --report lcov" #9437

krakovia-evm opened this issue Nov 29, 2024 · 4 comments · Fixed by #9438
Assignees
@DaniPopes
Labels
Cmd-forge-coverage Command: forge coverage T-bug Type: bug

Comments

@krakovia-evm
Copy link

krakovia-evm commented Nov 29, 2024 •
edited
Loading

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (27cabbd 2024-11-29T00:30:33.362570500Z)

What command(s) is the bug in?

forge coverage --report -lcov

Operating System

Windows

Describe the bug

I just noticed "forge coverage --report -lcov" doesn't work anymore basically in all my repos.
Each coverage reports wrong lines, for example comments with green.
image
image
image

did a test on virtual machine, clean vscode install and different addon to view .lcov files.
Same issues.
Here's a small project with the issue
(forge init --no-git, OZ 5 & a simple erc20 with tests)
test.zip
@krakovia-evm krakovia-evm added T-bug Type: bug T-needs-triage Type: this issue needs to be labelled labels Nov 29, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Nov 29, 2024
@DaniPopes DaniPopes self-assigned this Nov 29, 2024
@DaniPopes DaniPopes added Cmd-forge-coverage Command: forge coverage and removed T-needs-triage Type: this issue needs to be labelled labels Nov 29, 2024
@DaniPopes DaniPopes mentioned this issue Nov 30, 2024
Merged
@DaniPopes DaniPopes moved this from Todo to Ready For Review in Foundry Nov 30, 2024
@DaniPopes DaniPopes moved this from Ready For Review to In Progress in Foundry Nov 30, 2024
@DaniPopes DaniPopes moved this from In Progress to Ready For Review in Foundry Nov 30, 2024
@grandizzy
Copy link
Collaborator

@krakovia-evm moving discussion here, re #9438 (comment) I see the contract included even with the comment (that's before PR that fix this issue)

image

@krakovia-evm
Copy link
Author

@krakovia-evm moving discussion here, re #9438 (comment) I see the contract included even with the comment (that's before PR that fix this issue)

image

🤔 that's curious.
Seems it's the ascii art
/** █████████████████████████████████████████████████████████████████████████████ ████████████████████▒▒░░░░░░░░▒▒▒▓▒▒▒███▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓████████████████████ █████████████████▓░░░░░░░░░░░░░░░░░▒█████▒░░░░░░░░░░░░░░░░▒▓█████████████████ █████████████████▒░░░▒▓▓▓▓▓▓▓▒░░░░▒███████▒░░░▒▒▓▓███▓▓▓▒▒▒▒▓████████████████ █████████████████▒░▒████████████▒▒████████▓▒▓████████████▒▒▒▒████████████████ ████████████████▒░░▒████████████▓▒█████████▒█████████████▒▒▒▓████████████████ █████████████████▓░░▓███████████▓▒█████████▒▓███████████▓▒▒██████████████████ ███████████████████▒░▒████████████████████████████████▓▒▒▓███████████████████ ██████████████████████▒░▓███████████████████████████▓▒▓██████████████████████ █████████████████████████▒▒██████████████████████▓▒▒█████████████████████████ ███████████████████████████▓▒▒█████████████████▒▒████████████████████████████ ██████████████████████████████▓▒▓███████████▓▒▓██████████████████████████████ ████████████████████████████████▓▒▓███████▓▓█████████████████████████████████ ███████████████████████████████████▓▓██▓▓▓███████████████████████████████████ █████████████████████████████████████▒▒▓█████████████████████████████████████ ███████████████████████████████████▓▓██▓▓▓███████████████████████████████████ ██████████████████████▓▒▒▓███████▓▒▓█████▓▓████████▓▒▓███████████████████████ ██████████████████▓▒▒▒▒▒▒▓██████▓▒▓███████▓▒▓██████▓▓▓▓▓▓▓███████████████████ ████████████████▓▒▒▒▒▒▒▒▒▒█████▓▒▒▓███████▓▒▒▓█████▓▓▓▓▓▓▓▓▓▓████████████████ ███████████████▒▒▒▒▒▒▒▒▒▒▒▒████▒▒▓████████▓▓▓▓████▓▓▓▓▓▓▓▓▓▓▓▓███████████████ ██████████████▓▒▒▒▒▒▒▓███▓▒▓██▓▒▒▓█████████▓▓▓███▓▓█████▓▓▓▓▓▓▓██████████████ ██████████████▓▒▒▒▒▓███████▓▓█▓▒▒▓█████████▓▓▓██▓█████████▓▓▓▓▓██████████████ █████████████▓▒▒▒▒▒████████████▓▓▓▓███████▓▓▓▓████████████▓▓▓▓▓██████████████ █████████████▓▒▒▒▒▓████████████▓▓▓▓▓█████▓▓▓▓█████████████▓▓▓▓▓██████████████ ██████████████▓▒▒▒▒▓▓███████████▓▓▓▓▓▓▓▓▓▓▓▓█████████████▓▓▓▓▓▓██████████████ ███████████████▓▒▒▒▓▓▓▓▓▓███████▓▓▓▓▓▓▓▓▓▓▓▓▓████████▓▓▓▓▓▓▓▓▓███████████████ ████████████████▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█████████████████ ████████████████████▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█████████████████████ █████████████████████████████████████████████████████████████████████████████ */

@DaniPopes
Copy link
Member

Cannot reproduce with the fix PR #9438

@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Foundry Nov 30, 2024
@krakovia-evm
Copy link
Author

Cannot reproduce with the fix PR #9438

i owe you a coffee ser.
It's working on all my workspaces now.
TY! o/

DaniPopes added a commit that referenced this issue Dec 1, 2024
@DaniPopes
test: add regression test for #9437
8fb268f
DaniPopes added a commit that referenced this issue Dec 2, 2024
@DaniPopes
fix(coverage): special functions have no name (#9441)
168b239 
* fix(coverage): special functions have no name

* test: don't to_string

* test: rm --summary which is not --report=summary

* test: add regression test for #9437

* fmt

* docs
@grandizzy grandizzy moved this from Done to Completed in Foundry Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaniPopes DaniPopes

Labels
Cmd-forge-coverage Command: forge coverage T-bug Type: bug
Projects
Foundry
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(coverage): clean ups, use normalized source code for locations foundry-rs/foundry
3 participants
@grandizzy @DaniPopes @krakovia-evm