Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: identify hits for empty fallbacks #9458

Open
DaniPopes opened this issue Dec 2, 2024 · 0 comments
Open

coverage: identify hits for empty fallbacks #9458

DaniPopes opened this issue Dec 2, 2024 · 0 comments
Labels
Cmd-forge-coverage Command: forge coverage T-feature Type: feature T-to-investigate Type: to investigate

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Dec 2, 2024 •
edited
Loading

Component

Forge

Describe the feature you would like

Currently we can correctly identify hits for empty functions, but not constructors, fallbacks, or receives.

This means that if we were to stop ignoring them when empty, we would generate a report with no hits registered even if they did happen.

Additional context
@DaniPopes DaniPopes added T-feature Type: feature Cmd-forge-coverage Command: forge coverage T-to-investigate Type: to investigate labels Dec 2, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 2, 2024
@DaniPopes DaniPopes mentioned this issue Dec 2, 2024
Merged
Ramyromel added a commit to Ramyromel/foundry that referenced this issue Dec 3, 2024
@Ramyromel
Fix coverage for empty constructors, fallbacks, and receives
a893c82 
Fixes foundry-rs#9458

Update `crates/forge/src/coverage.rs` to include necessary imports for coverage reporting.

* Add imports for `HashMap`, `comfy_table`, `disassemble_bytes`, and `fs` to support coverage reporting functionality.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/foundry-rs/foundry/issues/9458?shareId=XXXX-XXXX-XXXX-XXXX).
@Ramyromel Ramyromel mentioned this issue Dec 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cmd-forge-coverage Command: forge coverage T-feature Type: feature T-to-investigate Type: to investigate
Projects
Foundry
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DaniPopes