Skip to content

Conversation

Rimeeeeee
Copy link
Contributor

@Rimeeeeee Rimeeeeee commented May 23, 2025

fixes #10609
removed redundant EthereumHardfork and OptimismHardfork
added standalone fxns spec_id_from_optimism_hardfork, spec_id_from_ethereum_hardfork and ethereum_hardfork_from_block_tag for support
added tests to test standalone fxns

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start
looks like we also need the inverse of chain +u64 -> Option<Hardfork>?

let's do a rewrite of

impl<T: Into<BlockNumberOrTag>> From<T> for EthereumHardfork {

as regular fn here first and then we move this to the hardforks crate

@Rimeeeeee Rimeeeeee requested a review from mattsse May 24, 2025 10:45
@Rimeeeeee Rimeeeeee requested review from zerosnacks and mattsse May 27, 2025 05:11
@zerosnacks
Copy link
Member

Lgtm! Pending final upstream changes in alloy-hardforks

Thanks @Rimeeeeee!

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 65650a6 into foundry-rs:master May 27, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry May 27, 2025
Dargon789 pushed a commit to Dargon789/foundry that referenced this pull request May 28, 2025
* chore: replaced anvil hardforks with alloy hardforks

* fixes

* fixes

* fixes

* removed redundant op and alloy hardforks enum

* fixes

* fixes

* bumped alloy hardforks and kept default to prague and isthmus

* bumped alloy-hardforks and fixes

---------

Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

chore: replace anvil hardforks with alloy-hardforks
3 participants