cast: s/build_tx/TxBuilder/ #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes foundry-rs#937 Refactoring to move away from function-with-hundred-arguments to a Builder pattern
gakonst
reviewed
Mar 28, 2022
sblOWPCKCR
force-pushed
the
tx_build
branch
3 times, most recently
from
868a9d3
to
6c76711
Compare
|
ready for review |
onbjerg
reviewed
Mar 31, 2022
gakonst
requested changes
Mar 31, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to move away from function-with-hundred-arguments to a Builder pattern
Fixes #937
TxBuilder constructs the tx on the fly, that's why the interface is not super consistent (
args()returns a future result, while other setters return &mut self), and provider needs to be passed to some of the setters.Alternatively, I can change TxBuilder to be just a glorified bag-of-arguments, and leave the actual transaction building in lib.tx. The downsides will be: 1) we'll still have 1 gigantic function that need to handle every field in TxBuilder; 2) it'll use a bit more memory
I'm not 100% confident in my Rust, so plz check for dumb things