feat: cast storage --solc-version CLI argument
#11321
Conversation
zugdev
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
|
bumping for feedback! |
|
thank you!
IMO storage related should be fine, we can extend if needed on other commands
The warning and error message are already displayed in each case. @zerosnacks wdyt on points above?
Yes, please add a test for this, there are samples in cast.rs |
This makes sense.
I agree.
I didn't find a file named My test set includes tests
Please, feel free to tag me with requests and feedback. |
|
Bumping! i don't mean to be annoying, I just want to work on other issues and I can make better PRs after this first review. |
crates/cast/src/cmd/storage.rs
Outdated
| project.compiler = { | ||
| if let Some(solc_req) = self.solc_version { | ||
| SolcCompiler::Specific(Solc::find_or_install(&solc_req)?) | ||
| } else if auto_detect { | ||
| SolcCompiler::AutoDetect | ||
| } else { | ||
| } else { | ||
| SolcCompiler::Specific(Solc::find_or_install(&version)?) | ||
| } | ||
| }; |
There was a problem hiding this comment.
this isn't formatted correctly, just run cargo +nightly fmt --all and it will fix it.
|
Hi! @zugdev still missing a rebase :D Sorry about that |
My bad will do it in a few minutes. |
|
pls give me a day no bandwidth today |
|
Hey! I had to rewrite a little bit to merge with some nice changes @DaniPopes introduced. Let me know about anything. |
Motivation
#9939 is a feature request for
--solc-versionas a CLI argument forcast storage. This is my first PR, please be as strict as possible so I can learn.Solution
User can override the detected version by passing
cast storage --solc-version <version>, I've added a conditional in case the argument is passed.I have a few observations:
castargumentMIN_SOLCor an invalid compiler version for that artifact? The warning and error message are already displayed in each case.PR Checklist