Skip to content

test(cheatcodes): strings with {} are not roundtrippable #11391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025
Merged

test(cheatcodes): strings with {} are not roundtrippable #11391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions crates/cheatcodes/src/json.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,15 @@ mod tests {
}

// Tests to ensure that conversion [DynSolValue] -> [serde_json::Value] -> [DynSolValue]
use proptest::prelude::ProptestConfig;
proptest::proptest! {
#![proptest_config(ProptestConfig {
cases: 99,
// These are flaky so persisting them is not useful in CI.
failure_persistence: None,
..Default::default()
})]

#[test]
fn test_json_roundtrip_guessed(v in guessable_types()) {
let json = serialize_value_as_json(v.clone()).unwrap();
Expand All @@ -729,9 +737,9 @@ mod tests {

#[test]
fn test_json_roundtrip(v in proptest::arbitrary::any::<DynSolValue>().prop_filter("filter out values without type", |v| v.as_type().is_some())) {
let json = serialize_value_as_json(v.clone()).unwrap();
let json = serialize_value_as_json(v.clone()).unwrap();
let value = parse_json_as(&json, &v.as_type().unwrap()).unwrap();
assert_eq!(value, v);
assert_eq!(value, v);
}
}
}
Loading