Skip to content

fix(forge): custom verifiers should not throw on unknown etherscan chains #11442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2025
Merged

fix(forge): custom verifiers should not throw on unknown etherscan chains #11442

merged 4 commits into from
Sep 9, 2025
+85 −19

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Aug 27, 2025 •
edited
Loading

Motivation

Solution

  • in place fix, needs a broader refactoring to reflect same code is used by etherscan-like verifiers and more tests for non-etherscan supported verifiers
  • consider backport to v1.3.3

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy marked this pull request as ready for review August 27, 2025 15:01
@grandizzy grandizzy marked this pull request as draft August 27, 2025 16:45
zerosnacks
zerosnacks reviewed Sep 8, 2025
View reviewed changes
zerosnacks
zerosnacks reviewed Sep 8, 2025
View reviewed changes
@grandizzy grandizzy marked this pull request as ready for review September 8, 2025 16:12
@grandizzy grandizzy requested a review from zerosnacks September 8, 2025 16:12
zerosnacks
zerosnacks approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@grandizzy grandizzy merged commit f60a1d8 into foundry-rs:master Sep 9, 2025
23 checks passed
@grandizzy grandizzy deleted the issue-11430 branch September 9, 2025 12:19
@github-project-automation github-project-automation bot moved this to Done in Foundry Sep 9, 2025
MerkleBoy pushed a commit to MerkleBoy/foundry that referenced this pull request Sep 17, 2025
@grandizzy @zerosnacks @MerkleBoy
fix(forge): custom verifiers should not throw on unknown etherscan ch…
bcf80bd 
…ains (foundry-rs#11442)

* fix(forge): check if supported chain in verifier client

* Apply suggestions from code review

* heck if verifier url passed if not etherscan

* Tests

---------

Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(forge verify-contract): Etherscan API URL Error when using blockscout
2 participants
@grandizzy @zerosnacks