chore(forge eip712): use solar from compiler output #11458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
klkvr,
mattsse,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
|
@DaniPopes looks like tests need to be updated (not a big deal), although not sure why that wasn't an issue before |
|
We didn't have a project before. This does call solc but with the minimum work possible |
|
oh sure, makes sense... |
0xrusowsky
previously approved these changes
Aug 28, 2025
onbjerg
approved these changes
Aug 28, 2025
| })?; | ||
|
|
||
| eyre::ensure!(compiler.sess().dcx.has_errors().is_ok(), "errors occurred"); | ||
| // `compiler.sess()` inside of `ProjectCompileOutput` is built with `with_buffer_emitter`. |
There was a problem hiding this comment.
Suggested change
| // `compiler.sess()` inside of `ProjectCompileOutput` is built with `with_buffer_emitter`. | |
| // SAFETY: `compiler.sess()` inside of `ProjectCompileOutput` is built with `with_buffer_emitter`. |
i find the preamble useful for context
There was a problem hiding this comment.
SAFETY should only be used for unsafe
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
* chore(forge eip712): use solar from compiler output * com * output * fix: actually select nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #11456.