-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(common): identify bytes and string slots using storageLayout #11476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
reviewed
Sep 3, 2025
zerosnacks
reviewed
Sep 3, 2025
zerosnacks
reviewed
Sep 4, 2025
zerosnacks
reviewed
Sep 4, 2025
zerosnacks
previously approved these changes
Sep 4, 2025
grandizzy
requested changes
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, left some comments / nits, pls check
grandizzy
approved these changes
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
…undry-rs#11476) * feat(common): identify bytes and string slots using storageLayout * fmt * clippy * aggregate and decode bytes and strings * cleanup * nits * clippy * fmt * nit * cleanup * identify the slots using the length of data in base slot value * nit * fix * fix mapping identification * nit * fmt * nit * Update crates/common/src/slot_identifier.rs * Update crates/common/src/slot_identifier.rs * cleanup: slot_identifier * cleanup * nit --------- Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
towards #3869
Solution
"encoding": "bytes"
in storage layoutbase_slot
slot of a bytes/string variable give it's range. See: https://docs.soliditylang.org/en/latest/internals/layout_in_storage.html#bytes-and-stringExample JSON output
PR Checklist