chore(sol_macro_gen): remove unlinked bytecode workaround #11613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mablr
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
mablr
commented
Sep 11, 2025
mablr
commented
Sep 11, 2025
| @@ -0,0 +1,27 @@ | |||
| // <https://github.com/foundry-rs/foundry/issues/9482> | |||
There was a problem hiding this comment.
I created a file for bind subcommand, so we can either:
- merge it to
cmd.rs - or move all three existing bind tests here
onbjerg
approved these changes
Sep 11, 2025
There was a problem hiding this comment.
looks good to me, I don't think we need a new CLI flag. would like @DaniPopes to take a look as well
changed your PR description to actively close #9482 as I do think it does as well
DaniPopes
approved these changes
Sep 11, 2025
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #9482
Related to #10291 and alloy-rs/core#935
Solution
As Alloy provides now
#[sol(ignore_unlinked)attribute, it's possible to ignore unlinked bytecode while parsing sol input.#[sol(ignore_unlinked)attribute to token stream inget_sol_inputPR Checklist