Fix: Replace unsafe mnemonic fallback with secure random generation #11644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorking7
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya,
zerosnacks and
onbjerg
as code owners
onbjerg
requested changes
Sep 15, 2025
crates/anvil/src/cmd.rs
Outdated
| Ok(mnemonic) => mnemonic.to_phrase(), | ||
| Err(_) => DEFAULT_MNEMONIC.to_string(), | ||
| Err(err) => { | ||
| warn!(target: "node", ?count, %err, "invalid mnemonic word count, falling back to 12-word random mnemonic"); |
There was a problem hiding this comment.
this error message is not correct, it might also be that the word is not in the dictionary
Co-authored-by: onbjerg <onbjerg@users.noreply.github.com>
onbjerg
requested changes
Sep 15, 2025
onbjerg
approved these changes
Sep 15, 2025
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
…oundry-rs#11644) * Update cmd.rs * Update crates/anvil/src/cmd.rs Co-authored-by: onbjerg <onbjerg@users.noreply.github.com> * Update cmd.rs * Update cmd.rs --------- Co-authored-by: onbjerg <onbjerg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Security Issue Fixed: Removed silent fallback to the well-known test mnemonic
"test test test test test test test test test test test junk"when invalid word count is provided to--mnemonic-random.Problem
When users specified an invalid word count (e.g.,
anvil --mnemonic-random 13), the code would silently fall back toDEFAULT_MNEMONIC, which is a publicly known test phrase. This created a security risk where users might unknowingly use predictable, insecure accounts.Solution