Skip to content

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Sep 16, 2025

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy
Copy link
Collaborator Author

@zerosnacks I tested on linux, could you please give it a try on mac, just run tests in a project through docker built image

docker run -v $PWD:/app ghcr.io/foundry-rs/foundry:fix-docker-aws "forge test --root /app"

thanks!

@grandizzy grandizzy changed the title fix(release): build docker x86_64 using host cross fix(release): build docker images with cargo instead cross Sep 16, 2025
@grandizzy grandizzy marked this pull request as ready for review September 16, 2025 07:52
@yash-atreya
Copy link
Member

@zerosnacks I tested on linux, could you please give it a try on mac, just run tests in a project through docker built image

docker run -v $PWD:/app ghcr.io/foundry-rs/foundry:fix-docker-aws "forge test --root /app"

thanks!

Tested locally on Apple Silicon
lgtm!

Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested on Mac Intel, works 👍

@grandizzy grandizzy merged commit 8722778 into master Sep 16, 2025
46 of 48 checks passed
@grandizzy grandizzy deleted the grandizzy/fix-docker-aws branch September 16, 2025 08:24
@github-project-automation github-project-automation bot moved this to Done in Foundry Sep 16, 2025
MerkleBoy pushed a commit to MerkleBoy/foundry that referenced this pull request Sep 17, 2025
@grandizzy grandizzy self-assigned this Sep 22, 2025
@grandizzy grandizzy moved this from Done to Completed in Foundry Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

bug: release workflow failed
3 participants