feat(forge): introduce network custom features, sunset Odyssey #11675

grandizzy · 2025-09-17T09:11:16Z

Motivation

closes Incompatible with the celo network, balanceOf(), transfer(), deal() and others do not work #11622
moves networks specific features (precompiles for now) in networks crate, reused in forge - enables Celo transfer precompile when running forge test with --celo
follow-up: apply to cast as well, so network features (precompiles, custom tx types) can be applied on all foundry components
superseeds refactor!: remove --odyssey #11688
Removes the --odyssey flag since Odyssey is being sunset, and we have equivalent flags that achieve the same behavior.
If you just need EIP7701, you can use --evm-version prague.
If you additionally need the P256 precompiles, you can use --evm-version osaka.
Test osaka_can_run_p256_precompile updated as some additional gas spent compared with odyssey.
Closes Sunset --odyssey flag #11681

Solution

PR Checklist

Added Tests
Added Documentation
Breaking changes

mattsse

very nice, just some comments/suggestions but we should proceed with this

mattsse · 2025-09-17T15:02:53Z

crates/evm/core/src/evm.rs

+    NetworkPrecompiles::default()
+        .odyssey(evm.inspector().is_odyssey())
+        .celo(evm.inspector().is_celo())
+        .inject(evm.precompiles_mut());


mattsse · 2025-09-17T15:11:40Z

crates/anvil/src/eth/backend/mem/mod.rs

+        precompiles_map
+            .extend(NetworkPrecompiles::default().odyssey(self.odyssey).celo(self.is_celo()).get());


so much better

mattsse · 2025-09-17T15:13:15Z

crates/evm/precompiles/src/lib.rs

+    /// Returns precompiles for configured networks.
+    pub fn get(self) -> BTreeMap<String, Address> {
+        let mut precompiles = BTreeMap::new();
+        if self.odyssey {
+            precompiles.insert(
+                PrecompileId::P256Verify.name().to_string(),
+                u64_to_address(P256VERIFY_ADDRESS),
+            );
+        }
+
+        if self.celo {
+            precompiles
+                .insert(PRECOMPILE_ID_CELO_TRANSFER.name().to_string(), CELO_TRANSFER_ADDRESS);
+        }
+        precompiles
+    }


can we rename this to get_ids or something?

yeah, I actually repurposed the crate foundry-evm-precompiles -> foundry-evm-networks because networks could come with more than custom precompiles, so we have now inject_precompiles and precompiles and we could add fns for custom txes or other stuff

mattsse · 2025-09-17T15:14:23Z

crates/forge/src/multi_runner.rs

    /// Whether to enable Odyssey features.
    pub odyssey: bool,
+    /// Whether to enable Celo precompiles.
+    pub celo: bool,


does it make sense to group this to

networks: NetworkPrecompiles

or similar?

less defaults, fields

done, looks much better

mattsse

lgtm!

yash-atreya · 2025-09-18T10:07:58Z

crates/anvil/src/eth/backend/executor.rs

-                        Some(celo_precompile::precompile())
-                    });
-            }
+            self.networks.inject_precompiles(evm.precompiles_mut());


nicely consolidates precompile injection

yash-atreya · 2025-09-18T10:08:23Z

crates/anvil/src/eth/backend/executor.rs

    /// Cumulative blob gas used by all executed transactions
    pub blob_gas_used: u64,
    pub enable_steps_tracing: bool,
-    pub odyssey: bool,


@grandizzy FYI, there will be conflicts with #11688

yep, going to include odyssey removal and superseded the other PR

In that case, relaying from #11688 (comment)

Can we also remove the WalletGetCapabilities and AnvilAddCapability endpoints? Now that we have the relay open source, along with the docker container that runs Anvil and relay together for local testing?
We don't need these in anvil anymore

not sure, does this mean that users will have to run relay for those? @onbjerg could you pls chime in?

They can run anvil + relay using the provided docker container: https://porto.sh/relay#local-development

kk, so not odyssey related endpoint?

will follow up in subsequent PR

zerosnacks

Nice!

DaniPopes

lgtm

do we want a separate config key for this? like networks.x

should we infer this from chain id if set?

DaniPopes · 2025-09-18T12:20:17Z

crates/evm/networks/src/lib.rs

+pub struct NetworkConfigs {
+    /// Enable Optimism network features.
+    #[arg(help_heading = "Networks", long, visible_alias = "optimism")]
+    #[serde(skip)]


why is this serde skipped?

this ends up in forge config and we don't have (yet) anything to add to forge if optimism set to true, hence decided not to include

please leave a comment

yep, added in cf1499e

grandizzy · 2025-09-18T15:04:17Z

going to open up a gh issues with follow ups to improve the impl by:

~~extend to cast~~ feat(cast): apply network precompiles for cast run and call #11720
~~determine networks from chain ids / fork urls~~ feat(cast): apply network precompiles for cast run and call #11720
add custom txes besides precompiles
improve configs for networks

github-project-automation bot added this to Foundry Sep 17, 2025

feat(forge): add precompiles crate

46cb1d9

grandizzy force-pushed the precompiles branch from 29f235c to 46cb1d9 Compare September 17, 2025 10:04

Nit - NetowrkPrecompiles

b72bef4

mattsse reviewed Sep 17, 2025

View reviewed changes

grandizzy added 5 commits September 18, 2025 09:05

Consolidate networks

ed4c4be

Merge branch 'master' into precompiles

e779e32

Remove anvil odyssey

e499fb1

Consolidate forge networks

2cf6545

More reuse

36cafc0

grandizzy changed the title ~~[WIP] feat(forge): add precompiles crate~~ [WIP] feat(forge): add network features crate Sep 18, 2025

Broader netwroks scope than precompiles

f7a064b

grandizzy force-pushed the precompiles branch from 896ceb5 to f7a064b Compare September 18, 2025 08:58

mattsse previously approved these changes Sep 18, 2025

View reviewed changes

grandizzy dismissed mattsse’s stale review via 6daa409 September 18, 2025 10:06

yash-atreya reviewed Sep 18, 2025

View reviewed changes

yash-atreya mentioned this pull request Sep 18, 2025

refactor!: remove --odyssey #11688

Closed

3 tasks

Remove odyssey

d8e0a79

grandizzy force-pushed the precompiles branch from 6daa409 to d8e0a79 Compare September 18, 2025 10:19

Merge branch 'master' into precompiles

29b13e0

grandizzy changed the title ~~[WIP] feat(forge): add network features crate~~ feat(forge): introduce network custom features Sep 18, 2025

grandizzy changed the title ~~feat(forge): introduce network custom features~~ feat(forge): introduce network custom features, sunset Odyssey Sep 18, 2025

grandizzy marked this pull request as ready for review September 18, 2025 10:35

grandizzy requested review from DaniPopes, zerosnacks, onbjerg and 0xrusowsky as code owners September 18, 2025 10:35

grandizzy requested review from yash-atreya and mattsse September 18, 2025 10:37

zerosnacks previously approved these changes Sep 18, 2025

View reviewed changes

DaniPopes reviewed Sep 18, 2025

View reviewed changes

Add comment re optimism skipped from forge config

cf1499e

grandizzy dismissed zerosnacks’s stale review via cf1499e September 18, 2025 13:44

DaniPopes approved these changes Sep 18, 2025

View reviewed changes

grandizzy merged commit 86d5c5b into foundry-rs:master Sep 18, 2025
25 checks passed

grandizzy deleted the precompiles branch September 18, 2025 15:34

github-project-automation bot moved this to Done in Foundry Sep 18, 2025

grandizzy self-assigned this Sep 22, 2025

grandizzy added this to the v1.4.0 milestone Sep 22, 2025

grandizzy moved this from Done to Completed in Foundry Sep 22, 2025

		precompiles_map
		.extend(NetworkPrecompiles::default().odyssey(self.odyssey).celo(self.is_celo()).get());

feat(forge): introduce network custom features, sunset Odyssey #11675

feat(forge): introduce network custom features, sunset Odyssey #11675

Uh oh!

Conversation

grandizzy commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Solution

PR Checklist

Uh oh!

mattsse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mattsse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yash-atreya Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yash-atreya Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zerosnacks left a comment

Choose a reason for hiding this comment

Uh oh!

DaniPopes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grandizzy commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

grandizzy commented Sep 17, 2025 •

edited

Loading

yash-atreya Sep 18, 2025 •

edited

Loading

yash-atreya Sep 18, 2025 •

edited

Loading

grandizzy commented Sep 18, 2025 •

edited

Loading