Skip to content

chore: pass project root to spinner #11740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2025
Merged

chore: pass project root to spinner #11740

merged 1 commit into from
Sep 21, 2025

Conversation

SWASTIC-7
Copy link
Contributor

Motivation

fixes #11738

Solution

Added project_root argument in SpinnerReported::spawn to avoid computing project_root on every call

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes changed the title fix: remove usage of foundry_config by using project_root argument in spawn f… chore: pass project root to spinner Sep 21, 2025
DaniPopes
DaniPopes approved these changes Sep 21, 2025
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit 1cc7cc9 into foundry-rs:master Sep 21, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept a root argument in SpinnerReporter::spawn
2 participants
@SWASTIC-7 @DaniPopes