fix(coverage): sync implementation with forge test #11801
Merged
+80
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage was calling a low level function of forge test args, which does not setup stuff like config.fuzz.gas_report_samples, EvmArgs, etc., as well as missing options in the test runner builder etc. This means that `forge coverage` falls out of sync gradually with `forge test`. One of the options which was thus missed, `gas_report_samples`, controls how many traces are saved from fuzz and invariant tests, which with the recent addition of tracing for backtraces means we are storing a lot of traces unnecessarily, massively increasing memory usage.
DaniPopes
requested review from
mattsse,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
onbjerg
previously approved these changes
Sep 24, 2025
DaniPopes
commented
Sep 24, 2025
| .dynamic_test_linking(config.dynamic_test_linking) | ||
| .quiet(shell::is_json() || self.junit) | ||
| .files(self.get_sources_to_compile(&config, &filter)?); | ||
| let output = compiler.compile(&project)?; |
There was a problem hiding this comment.
this doesn't sync the compilation, which is currently also mismatched due to get_sources_to_compile and dynamic_test_linking
onbjerg
approved these changes
Sep 24, 2025
yash-atreya
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage was calling a low level function of forge test args, which does not setup stuff like config.fuzz.gas_report_samples, EvmArgs, etc., as well as missing options in the test runner builder etc.
This means that
forge coveragefalls out of sync gradually withforge test. One of the options which was thus missed,gas_report_samples, controls how many traces are saved from fuzz and invariant tests, which with the recent addition of tracing for backtraces means we are storing a lot of traces unnecessarily, massively increasing memory usage.