feat(anvil): add support for anvil_getBlobSidecarsByBlockId
#11828
Conversation
- Added primitive Engine REST API
There was a problem hiding this comment.
cool, need to think about the regular http GET routes support a bit,
can we limit this pr to just the extra anvil endpoint that returns BlobTransactionSidecar (all blobs in a block)
and think about adding support for GET requests and the beacon route in a followup pr?
crates/anvil/server/src/beacon.rs
Outdated
| pub fn beacon_router<Beacon: BeaconApiHandler>(beacon: Beacon) -> Router { | ||
| Router::new() | ||
| .route("/v1/beacon/blob_sidecars/{block_id}", get(get_blob_sidecars_by_block_id::<Beacon>)) | ||
| .with_state(beacon) | ||
| } |
There was a problem hiding this comment.
ah wait, we do need this because this is a regular get request -.-
There was a problem hiding this comment.
yess it was actually less trivial than I expected 😅
|
no problem i'll split this PR 👌 (...tomorrow morning) |
| pub fn get_blob_sidecars_by_block_id( | ||
| &self, | ||
| block_id: BlockId, | ||
| ) -> Result<Option<Vec<BlobTransactionSidecar>>> { |
There was a problem hiding this comment.
We return a Vec<BlobTransactionSidecar>, is this what we want? or would it be better to flatten this into a single BlobTransactionSidecar ?
There was a problem hiding this comment.
let's do just BlobTransactionSidecar which is usually the format required
There was a problem hiding this comment.
I think a basic fold will do the job as we don't have FromIterator impl for BlobTransactionSidecar (could be a follow up in alloy btw)
mablr
requested review from
DaniPopes,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
mablr
changed the title
anvil_getBlobSidecarsByBlockIdanvil_getBlobSidecarsByBlockId
| pub fn get_blob_sidecars_by_block_id( | ||
| &self, | ||
| block_id: BlockId, | ||
| ) -> Result<Option<Vec<BlobTransactionSidecar>>> { |
There was a problem hiding this comment.
let's do just BlobTransactionSidecar which is usually the format required
Motivation
towards #11797
Solution
anvil_getBlobSidecarsByBlockIdendpointPR Checklist