Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forge): add hardware wallet support to forge script #1764

Merged
merged 3 commits into from
May 29, 2022
Merged

feat(forge): add hardware wallet support to forge script #1764

merged 3 commits into from
May 29, 2022

Conversation

joshieDo
Copy link
Collaborator

Motivation

Supports trezor and ledger as signers.

Tested successfully on trezor. It should work, but if anyone has a ledger to test, it would be nice.

Solution

@joshieDo joshieDo mentioned this pull request May 29, 2022
Merged
8 tasks
gakonst
gakonst approved these changes May 29, 2022
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hype hype

@gakonst gakonst merged commit 7586722 into foundry-rs:master May 29, 2022
@onbjerg onbjerg added the T-feature Type: feature label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshieDo @gakonst @onbjerg