perf(evm): only store storage slot diffs and reconstruct full storage on request #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
changed the title
shekhirin
force-pushed
the
fix-state-storage-more
branch
from
a2f4a7a to
fc40e25
Compare
mattsse
reviewed
Sep 13, 2022
evm/src/executor/inspector/tracer.rs
Outdated
Comment on lines
107
to
110
| .last() | ||
| .expect("not enough contract journal entries") | ||
| .last() | ||
| .expect("not enough call journal entries"); |
There was a problem hiding this comment.
this should always work since, revm initializes this with vec![vec![]] and has an entry at this point
There was a problem hiding this comment.
let's add as comment in the code?
Comment on lines
+353
to
+354
| /// Change of the contract state after step execution (effect of the SLOAD/SSTORE instructions) | ||
| pub state_diff: Option<(U256, U256)>, |
shekhirin
force-pushed
the
fix-state-storage-more
branch
from
a1ba35b to
6e5a613
Compare
|
There are still some bugs in |
|
@mattsse not sure if it's fine to pin |
gakonst
reviewed
Sep 15, 2022
evm/src/executor/inspector/tracer.rs
Outdated
Comment on lines
107
to
110
| .last() | ||
| .expect("not enough contract journal entries") | ||
| .last() | ||
| .expect("not enough call journal entries"); |
There was a problem hiding this comment.
let's add as comment in the code?
shekhirin
force-pushed
the
fix-state-storage-more
branch
from
ab9567d to
6098f45
Compare
agree, merging since this is already a big improvement |
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
… on request (foundry-rs#3198) * fix: breaking changes geth trace data * fix: only clone contract state * a bit more fixes n improvements * revertme: bump revm to git * track diffs, reconstruct the storage on request * add comments * omit gas refund if it's 0 (go has omitempty on this field) * add comment regarding gas cost calculation & fix storage emptiness * show storage in response only on SLOAD/SSTORE * reorganize Inspector impl for Tracer * improve unwrap comment Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
continued work on top of #3187
relevant piece of geth code: https://github.com/ethereum/go-ethereum/blob/366d2169fbc0e0f803b68c042b77b6b480836dbc/eth/tracers/logger/logger.go#L181-L206
Demo
Deposit WETH and debug this transaction
Check
SLOADinstruction and storage slots associated with it (before, during, after)Check
SSTOREinstruction and storage slots associated with it (before, during, after)