-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new expectCall
cheatcode variants
#4413
Conversation
expectCall
cheatcode variantexpectCall
cheatcode variants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! tests are great as well! comments below are just stylistic suggestions, you can disregard them if not to your liking
Whoops
5d1c83a
to
6ad536b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The real solution I'd love for all these would be a builder pattern abstraction.
Overview
Adds two new variants of the
expectCall
cheatcode that allows for asserting the amount of gas passed to a call.Motivation
Ran into a situation where I need to assert that the amount of gas passed to a nested call is correct in a test.