-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly releases #459
Nightly releases #459
Conversation
That's a great PR. Do you have any thoughts on packaging? I was thinking brew for mac, choco for windows and apt for linux. For brew, we need to PR a formula. For apt things can get a bit complicated and for choco i haver absolutely no idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - any outstanding issues we need to follow up with?
- `name` defaults to `tag_name` - `GITHUB_TOKEN` is not used from environment
tag_name: ${{ env.TAG_NAME }} | ||
draft: ${{ env.IS_NIGHTLY }} | ||
body: ${{ steps.build_changelog.outputs.changelog }} | ||
files: ${{ steps.artifacts.outputs.file_name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No thoughts on packaging so far. It should be easy-ish to add, so I think we should add it once we are closer to our first stable release. That would also give us time to figure out what kind of package managers we want to support as well |
For brew, maybe checkout https://sake.sh Rust support is available dont believe their out of date readme |
Should be good to go now except for #459 (comment) |
Incredible work - gonna trigger a manual release |
Adds nightly releases and cleans up the release workflow.
Nightly releases are put under a draft version and the workflow is automatically run every day at midnight GitHub-time.
The release has archive files for macOS, Linux and Windows. Each archive contains both the
forge
andcast
binaries and nothing else.The archive files have predictable names that work well with scripts that pull specific versions off of GitHub releases (such as https://github.com/onbjerg/foundry-action).
An example release can be seen here: https://github.com/onbjerg/foundry/releases/v0.0.1
As an aside, when we do start releasing stable versions we should probably consider adding a changelog and using that for the release descriptions.