Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly releases #459

Merged
merged 11 commits into from
Jan 15, 2022
Merged

Nightly releases #459

merged 11 commits into from
Jan 15, 2022

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Jan 15, 2022

Adds nightly releases and cleans up the release workflow.

Nightly releases are put under a draft version and the workflow is automatically run every day at midnight GitHub-time.

The release has archive files for macOS, Linux and Windows. Each archive contains both the forge and cast binaries and nothing else.

The archive files have predictable names that work well with scripts that pull specific versions off of GitHub releases (such as https://github.com/onbjerg/foundry-action).

An example release can be seen here: https://github.com/onbjerg/foundry/releases/v0.0.1

As an aside, when we do start releasing stable versions we should probably consider adding a changelog and using that for the release descriptions.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@odyslam
Copy link
Contributor

odyslam commented Jan 15, 2022

That's a great PR.

Do you have any thoughts on packaging? I was thinking brew for mac, choco for windows and apt for linux.

For brew, we need to PR a formula. For apt things can get a bit complicated and for choco i haver absolutely no idea

Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - any outstanding issues we need to follow up with?

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
- `name` defaults to `tag_name`
- `GITHUB_TOKEN` is not used from environment
Comment on lines +100 to +103
tag_name: ${{ env.TAG_NAME }}
draft: ${{ env.IS_NIGHTLY }}
body: ${{ steps.build_changelog.outputs.changelog }}
files: ${{ steps.artifacts.outputs.file_name }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a token here to set the committer's identity, but that requires a personal access token. See here.

@gakonst let me know if that is something you want to do, then I'll add it (just tell me the name of the secret)

@onbjerg
Copy link
Member Author

onbjerg commented Jan 15, 2022

Do you have any thoughts on packaging? I was thinking brew for mac, choco for windows and apt for linux.

No thoughts on packaging so far. It should be easy-ish to add, so I think we should add it once we are closer to our first stable release. That would also give us time to figure out what kind of package managers we want to support as well

@sambacha
Copy link
Contributor

sambacha commented Jan 15, 2022

For brew, maybe checkout https://sake.sh

Rust support is available dont believe their out of date readme

@onbjerg
Copy link
Member Author

onbjerg commented Jan 15, 2022

Should be good to go now except for #459 (comment)

@gakonst
Copy link
Member

gakonst commented Jan 15, 2022

Incredible work - gonna trigger a manual release

@gakonst gakonst merged commit d092dbe into foundry-rs:master Jan 15, 2022
@onbjerg onbjerg deleted the nightly-release branch January 17, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants