feat(evm): support multiple languages for deriveKey cheatcode #4688
Conversation
| } | ||
| HEVMCalls::DeriveKey1(inner) => derive_key(&inner.0, &inner.1, inner.2), | ||
| HEVMCalls::DeriveKey1(inner) => derive_key::<English>(&inner.0, &inner.1, inner.2), | ||
| HEVMCalls::DeriveKey2(inner) => match inner.2.as_str() { |
There was a problem hiding this comment.
I'd like to have this as standalone function derive_key_with_wordlist that accepts the wordlist as str. perhaps even worth having an enum for this
|
|
|
pending another fix summa-tx/coins#120 |
Cargo.toml
Outdated
| ethers-signers = { git = "https://github.com/0xYYY/ethers-rs", branch = "chore/bump-bitcoin-rs" } | ||
| ethers-middleware = { git = "https://github.com/0xYYY/ethers-rs", branch = "chore/bump-bitcoin-rs" } | ||
| ethers-etherscan = { git = "https://github.com/0xYYY/ethers-rs", branch = "chore/bump-bitcoin-rs" } | ||
| ethers-solc = { git = "https://github.com/0xYYY/ethers-rs", branch = "chore/bump-bitcoin-rs" } |
There was a problem hiding this comment.
We don't depend on ethers git anymore, can this be in a added in the next ethers release?
|
hey @0xYYY — do you plan on getting back to this soon? |
yeah, plan to finish this around next week |
0xYYY
force-pushed
the
feat/evm-cheatcode-derive-multilang
branch
from
3b7a094
to
d1d4f5e
Compare
|
hmm seems we have some tests failing? |
yeah, but weirdly can't see any details about why the tests failed 
|
seems like the failing tests have ben re-ran and all tests have passed now |
|
yup guessed they were just outage/unrelated failures, nice! will wait for matt to review/merge—nice work :) |
|
hey @0xYYY — do you think we could rebase this? sorry for the extra work, but we recently refactored the abigen part of cheatcodes so will need to redo that bit |
no prob, on it |
0xYYY
force-pushed
the
feat/evm-cheatcode-derive-multilang
branch
from
06b5467
to
16a86e6
Compare
hi @mattsse, pls let me know if there are any changes that i can make to push forward this pr, thx |
|
thanks @Evalir for pushing this over the line |
Motivation
Resolves #4560.
Solution
Add support for other languages' wordlist in summa-tx/coins#119.