fix(invariant): 🐛 check for assert failures on handlers #4980

bronzelle · 2023-05-18T21:13:22Z

Motivation

fixes #4718

Solution

check for assert failures on handler call result

mattsse

nice find.

this could have an impact on efficiency but this is the only way to, well, ensure success.

given that this fixes the error, I think this should be included.

…5013)

fix(invariant): 🐛 check for assert failures on handlers

6b57178

mattsse approved these changes May 19, 2023

View reviewed changes

mattsse merged commit c331b5e into foundry-rs:master May 19, 2023

Evalir added a commit that referenced this pull request May 23, 2023

fix(invariant): revert check for assert failures on handlers #4980

218d40b

Evalir mentioned this pull request May 23, 2023

Revert fix(invariant): revert check for assert failures on handlers #4980 #5013

Merged

mattsse pushed a commit that referenced this pull request May 23, 2023

fix(invariant): revert check for assert failures on handlers #4980 (#…

59f026f

…5013)

mds1 mentioned this pull request Jun 30, 2023

Function-level assertions don't work when using invariants. #4718

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(invariant): 🐛 check for assert failures on handlers #4980

fix(invariant): 🐛 check for assert failures on handlers #4980

bronzelle commented May 18, 2023

mattsse left a comment

fix(invariant): 🐛 check for assert failures on handlers #4980

fix(invariant): 🐛 check for assert failures on handlers #4980

Conversation

bronzelle commented May 18, 2023

Motivation

Solution

mattsse left a comment

Choose a reason for hiding this comment