-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cheatcodes): vm.skip(bool)
for skipping tests
#5205
Conversation
vm.skip(bool)
for skipping testsvm.skip(bool)
for skipping tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@mds1 I think we'll merge this initial version that only works at the test level to keep test runner changes minimal—adding a reason string or making it work correctly at the set up level could involve moving a bit more code and I'd like to add this incrementally in another PR |
Thank you for working on this. :) |
Motivation
Closes #1123
Solution
Adds a
vm.skip(bool)
cheatcode that marks tests as skipped. It also moves the test runner to use aTestStatus
enum to mark success, failure, or a skipped test, which is the bulk of the work here really.One thing I noticed is that the handling and return types between normal/invariant/fuzz tests are pretty different. When we revisit the test runner we should try and streamline the handling of all of these so we can properly detect EVM errors in an easier way.
TODO:
vm.skip(bool)
Sample output: