feat(cast): subscribe to logs using websockets #5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
requested review from
mattsse and
Evalir
and removed request for
mattsse
|
hey @bernard-wagner just merged #5571 — should be good to continue |
bernard-wagner
force-pushed
the
subscribe
branch
from
83e6f12 to
13ee448
Compare
bernard-wagner
commented
Sep 5, 2023
bernard-wagner
commented
Sep 5, 2023
|
@Evalir open question: Should this be a separate command or should it use a |
|
hmm i think |
Evalir
reviewed
Sep 11, 2023
crates/cast/src/filters.rs
Outdated
| use foundry_common::abi::{get_event, parse_tokens}; | ||
| use itertools::Itertools; | ||
|
|
||
| /// First tries to parse the `sig_or_topic` as an event signature. If successful, `topics_or_args` |
There was a problem hiding this comment.
do these docs go here? unsure if they correspond to build_filter
bernard-wagner
force-pushed
the
subscribe
branch
2 times, most recently
from
c3394ca to
1bb5bde
Compare
bernard-wagner
force-pushed
the
subscribe
branch
from
1bb5bde to
97cc692
Compare
|
@Evalir apologies for all the force pushes. Moved to |
bernard-wagner
force-pushed
the
subscribe
branch
from
82ec012 to
97cc692
Compare
Evalir
approved these changes
Sep 12, 2023
mikelodder7
pushed a commit
to LIT-Protocol/foundry
that referenced
this pull request
Sep 12, 2023
* feat(cast): subscribe to logs * undo generic signal * fix tokio signal feature --------- Co-authored-by: Enrique Ortiz <hi@enriqueortiz.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on #5571
Motivation
It is useful to monitor for events emitted.
Solution
Introduces:
cast subscribeBuilding on the introduction of websockets, allow subscribing to events using the same syntax as
cast logs.Some additional changes
to_jsonlogic to support streaming.Moved filter logic from
logs.rstofilters.rsto enable reuse.If
--to-blockis specified, subscribe tonewHeadsand exits loop when target block has been reached.