refactor: move evm-spec-id to config #5786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
approved these changes
Sep 6, 2023
Evalir
force-pushed
the
matt/move-evm-spec-to-config
branch
from
4d5a77f to
f9d1720
Compare
Evalir
approved these changes
Sep 6, 2023
| @@ -112,24 +111,6 @@ pub fn halt_to_instruction_result(halt: Halt) -> InstructionResult { | |||
| } | |||
| } | |||
|
|
|||
| /// Converts an `EvmVersion` into a `SpecId`. | |||
There was a problem hiding this comment.
removed this as this was duped from this pr onwards
| @@ -255,6 +259,24 @@ where | |||
| Ok(num) | |||
| } | |||
|
|
|||
| /// Returns the [SpecId] derived from [EvmVersion] | |||
| #[inline] | |||
| pub fn evm_spec_id(evm_version: &EvmVersion) -> SpecId { | |||
There was a problem hiding this comment.
wrapped this in a simple util function, and we use this on config
|
gg |
mikelodder7
pushed a commit
to LIT-Protocol/foundry
that referenced
this pull request
Sep 12, 2023
* refactor: move evm-spec-id to config * chore: make util general and wrap it on config * chore: remove duped util on evm crate * chore: fix fixtures --------- Co-authored-by: Enrique Ortiz <hi@enriqueortiz.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
prep for #5782
this makes it easier to access the spec id required for the evm from the config
Solution