Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create2 suffix regex #5802

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Fix create2 suffix regex #5802

merged 1 commit into from
Sep 9, 2023

Conversation

igorline
Copy link
Contributor

@igorline igorline commented Sep 8, 2023

Motivation

While fixing previously prefix I broke suffix 🤦‍♂️ regex matching for create2 and suffered from it today

Solution

Adding $ to regex expression and the test

mattsse
mattsse approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@mattsse mattsse merged commit d5c51a5 into foundry-rs:master Sep 9, 2023
15 checks passed
@igorline igorline deleted the fix-suffix-create2 branch September 9, 2023 11:45
mikelodder7 pushed a commit to LIT-Protocol/foundry that referenced this pull request Sep 12, 2023
@igorline @mikelodder7
fix: add $ to suffix regex to ensure wallet address ending with speci…
ad5e3b5 
…fied hex string (foundry-rs#5802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorline @mattsse