Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when neither to nor --create are present #6175

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Oct 30, 2023

Motivation

I have just wasted some ETH by running command cast send --value X --rpc-url mainnet without to param :(
cast send --help has the following statement:

Arguments:
  [TO]
          The destination of the transaction.
          
          If not provided, you must use cast send --create.

However, by default, cast send without to will send transaction to zero address

Solution

Raise error when cast send is called without both to and --create

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes,
I'm very sorry to hear that...

@mattsse mattsse merged commit 94ae897 into foundry-rs:master Oct 30, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants