Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cheatcodes): Record Account and Storage Access Cheatcodes #6310

Merged
merged 19 commits into from
Nov 17, 2023
Merged

feat(cheatcodes): Record Account and Storage Access Cheatcodes #6310

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4d1f96c
Record storage and account access cheatcodes
refcell Oct 23, 2023
b7da13f
expand record access cheatcode interface
Inphi Nov 13, 2023
349469e
fix small doc comment nit
refcell Nov 15, 2023
924d700
fix(cheatcodes): account access doc comment
refcell Nov 15, 2023
5684e20
fix(cheatcodes): clarify reverted account access status
refcell Nov 15, 2023
f10b03d
fix(cheatcodes): clarify balance doc comments
refcell Nov 15, 2023
7d2d0c2
fix(cheatcodes): clarify initialized account access field in doc comment
refcell Nov 15, 2023
03ab22f
update Access kind to include Resumed account access
Inphi Nov 14, 2023
b1798d4
cleanup Resume logic
Inphi Nov 15, 2023
8f5cb9b
fmt
Inphi Nov 15, 2023
5a63bba
remove unused Resume access kind
Inphi Nov 16, 2023
055d3d9
add chain_id to AccountAccess
Inphi Nov 16, 2023
9748aff
Update crates/cheatcodes/spec/src/vm.rs
Inphi Nov 16, 2023
f34ebe5
add ChainInfo struct; address PR comments
Inphi Nov 16, 2023
c454b3b
avoid old skool ref mut
Inphi Nov 16, 2023
5aff57d
tidy code per pr review
Inphi Nov 16, 2023
95f0326
rmeove unused import
Inphi Nov 16, 2023
ca03ab0
address nits
Inphi Nov 17, 2023
d032d9f
selfdesutrct on record ctx check
Inphi Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/abi/abi/HEVM.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ struct DirEntry { string errorMessage; string path; uint64 depth; bool isDir; bo
struct FsMetadata { bool isDir; bool isSymlink; uint256 length; bool readOnly; uint256 modified; uint256 accessed; uint256 created; }
struct Wallet { address addr; uint256 publicKeyX; uint256 publicKeyY; uint256 privateKey; }
struct FfiResult { int32 exitCode; bytes stdout; bytes stderr; }
struct AccountAccess { address accessor; address account; uint256 kind; bool initialized; uint256 oldBalance; uint256 newBalance; bytes deployedCode; uint256 value; bytes data; bool reverted; StorageAccess[] storageAccesses; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the enum definition in this file and that instead of uint256 kind?

Copy link
Contributor Author

@Inphi Inphi Nov 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup will do. Though currently running into an abigen issue where it fails to generate proper bindings for an AccountAccess with too many fields.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah interesting, should be ok if we can't use the enum here since we can still use in Vm.sol in forge-std, so will defer to you + @mattsse / @Evalir here about the abigen issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it working by replacing both chainId and forkId with a struct h/t @refcell . Good to do anyways if we'll be adding this info to the rest of the cheatcode interface.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't worry about it, crates/abi is deprecated and will be removed soon. It's currently only used for trace/log decoding

struct StorageAccess { address account; bytes32 slot; bool isWrite; bytes32 previousValue; bytes32 newValue; bool reverted; }
Inphi marked this conversation as resolved.
Show resolved Hide resolved

allowCheatcodes(address)

Expand Down Expand Up @@ -84,6 +86,9 @@ record()
accesses(address)(bytes32[], bytes32[])
skip(bool)

startStateDiffRecording()
stopAndReturnStateDiff()(AccountAccess[])

recordLogs()
getRecordedLogs()(Log[])

Expand Down
247 changes: 247 additions & 0 deletions crates/abi/src/bindings/hevm.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading