Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve cast performance on macos - Only load root TLS certificates with HTTPs rpc-url #6350

Merged
merged 1 commit into from
Nov 18, 2023
Merged

fix: Improve cast performance on macos - Only load root TLS certificates with HTTPs rpc-url #6350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/common/src/runtime_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@ impl RuntimeClient {
async fn connect(&self) -> Result<InnerClient, RuntimeClientError> {
match self.url.scheme() {
"http" | "https" => {
let mut client_builder = reqwest::Client::builder().timeout(self.timeout);
let mut client_builder = reqwest::Client::builder()
.timeout(self.timeout)
.tls_built_in_root_certs(self.url.scheme() == "https");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, this always defaults to true but we only need it if the provider URL is https.

let mut headers = reqwest::header::HeaderMap::new();

if let Some(jwt) = self.jwt.as_ref() {
Expand Down