Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove foundry-binder #6405

Merged
merged 1 commit into from
Nov 22, 2023
Merged

chore: remove foundry-binder #6405

merged 1 commit into from
Nov 22, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Nov 22, 2023 •
edited
Loading

Motivation

Removing Ethers. Added in #1257.
This crate is separate from the rest of the workspace.

Solution

mattsse
mattsse approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable, we still have forge bind

Evalir
Evalir approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good w/ me, we should point ppl to forge bind

@DaniPopes DaniPopes merged commit 89f74f2 into master Nov 22, 2023
20 checks passed
@DaniPopes DaniPopes deleted the dani/rm-foundry-binder branch November 22, 2023 19:41
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Evalir Evalir Evalir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @mattsse @Evalir