Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sender_nonce shadowing #6589

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix sender_nonce shadowing #6589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c74334
Fix sender_nonce shadowing
klkvr Dec 12, 2023
0091a3f
Fix sender_nonce
klkvr Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crates/forge/bin/cmd/script/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ impl ScriptRunner {
.map(|traces| (TraceKind::Deployment, traces))
.collect();

let sender_nonce = self.executor.get_nonce(CALLER)?;
let address = CALLER.create(sender_nonce);
let address = CALLER.create(self.executor.get_nonce(CALLER)?);

// Set the contracts initial balance before deployment, so it is available during the
// construction
Expand Down
3 changes: 1 addition & 2 deletions crates/forge/src/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,7 @@ impl<'a> ContractRunner<'a> {
}
}

let sender_nonce = self.executor.get_nonce(self.sender)?;
let address = self.sender.create(sender_nonce);
let address = self.sender.create(self.executor.get_nonce(self.sender)?);

// Set the contracts initial balance before deployment, so it is available during
// construction
Expand Down