Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt: sort derives #6663

Merged
merged 1 commit into from
Dec 24, 2023
Merged

fmt: sort derives #6663

merged 1 commit into from
Dec 24, 2023

Conversation

DaniPopes
Copy link
Member

Motivation

Consistency (OCD)

ORDER = [
    "Clone",
    "Copy",
    "Debug",
    "Default",
    "PartialEq",
    "Eq",
    "PartialOrd",
    "Ord",
    "Hash",
    "Serialize",
    "Deserialize",
]

Solution

Evalir
Evalir approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for curing my ocd

@DaniPopes DaniPopes merged commit f11da38 into master Dec 24, 2023
19 checks passed
@DaniPopes DaniPopes deleted the dani/fmt-derives branch December 24, 2023 21:24
RPate97 pushed a commit to RPate97/foundry that referenced this pull request Jan 12, 2024
@DaniPopes @RPate97
fmt: sort derives (foundry-rs#6663)
19f012b
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@onbjerg onbjerg Awaiting requested review from onbjerg

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @Evalir